Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve google.api support for req without body #61

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

sudorandom
Copy link
Owner

@sudorandom sudorandom commented Jan 30, 2025

I believe this resolves #58 and #60. There are improvements to make, but this should fix the most glaring issues.

So now these options:

 option (google.api.http) = {
      post: "/foo4"
      body: "data.text"
    };

correctly resolve into "data" and "text" fields.

This PR also adds some warnings whenever fields can't be resolved this way.

@sudorandom sudorandom merged commit f5c816f into main Jan 31, 2025
6 checks passed
@sudorandom sudorandom deleted the google-api-nested-params branch January 31, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant