fix: support for editions

sudorandom · Aug 9, 2024 · 055cfff · 055cfff
1 parent df44d47
commit 055cfff
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/internal/converter/converter.go b/internal/converter/converter.go
@@ -223,10 +223,15 @@ func Convert(req *pluginpb.CodeGeneratorRequest) (*pluginpb.CodeGeneratorRespons
 		})
 	}
 
-	features := uint64(pluginpb.CodeGeneratorResponse_FEATURE_PROTO3_OPTIONAL)
+	features := uint64(pluginpb.CodeGeneratorResponse_FEATURE_PROTO3_OPTIONAL) | uint64(pluginpb.CodeGeneratorResponse_FEATURE_SUPPORTS_EDITIONS)
+	minimumEdition := int32(descriptorpb.Edition_EDITION_PROTO2)
+	maximumEdition := int32(descriptorpb.Edition_EDITION_MAX)
 	return &pluginpb.CodeGeneratorResponse{
-		File:              files,
+		Error:             new(string),
 		SupportedFeatures: &features,
+		MinimumEdition:    &minimumEdition,
+		MaximumEdition:    &maximumEdition,
+		File:              files,
 	}, nil
 }
 

diff --git a/internal/converter/fixtures/editions_2023.proto b/internal/converter/fixtures/editions_2023.proto
@@ -1,5 +1,7 @@
 edition = "2023";
 
+package editions;
+
 option features.enum_type = CLOSED;
 
 message Person {