chore(Debug/Scripting): improve debug errors during the unloading scr…

…ipts (azerothcore#19643) * chore(Debug/Scripting): improve debug errors during script unloading * add the script name to increase debug informations and ensure to derefence script pointers
sudlud · Aug 21, 2024 · db7183a · db7183a
1 parent ef4e0c0
commit db7183a
Showing 1 changed file with 17 additions and 2 deletions.
diff --git a/src/server/game/Scripting/ScriptMgr.cpp b/src/server/game/Scripting/ScriptMgr.cpp
@@ -30,9 +30,24 @@ namespace
     template<typename T>
     inline void SCR_CLEAR()
     {
-        for (auto const& [scriptID, script] : ScriptRegistry<T>::ScriptPointerList)
+        for (auto& [scriptID, script] : ScriptRegistry<T>::ScriptPointerList)
         {
-            delete script;
+            try
+            {
+                if(script)
+                {
+                    delete script;
+                    script = nullptr;
+                }
+            }
+            catch (const std::exception& e)
+            {
+                LOG_ERROR("scripts.unloading", "Failed to unload script {} with ID: {}. Error: {}", script->GetName(), scriptID, e.what());
+            }
+            catch (...)
+            {
+                LOG_ERROR("scripts.unloading", "Failed to unload script {} with ID: {}. Unknown error occurred.", script->GetName(), scriptID);
+            }
         }
 
         ScriptRegistry<T>::ScriptPointerList.clear();