Skip to content

Commit

Permalink
apps(docker): Fix Warnings in Dockerfile (azerothcore#19537)
Browse files Browse the repository at this point in the history
  • Loading branch information
michaeldelago authored Aug 18, 2024
1 parent adff3c3 commit af1a6f3
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions apps/docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ FROM ubuntu:$UBUNTU_VERSION AS skeleton
ARG DOCKER=1
ARG DEBIAN_FRONTEND=noninteractive

ENV TZ=$TZ
ENV AC_FORCE_CREATE_DB=1

RUN mkdir -pv \
Expand All @@ -29,11 +28,12 @@ RUN mkdir -pv \
/azerothcore/build

# Configure Timezone
RUN apt-get update \
&& apt-get install -y tzdata ca-certificates \
&& ln -snf /usr/share/zoneinfo/$TZ /etc/localtime \
&& echo $TZ > /etc/timezone \
&& dpkg-reconfigure --frontend noninteractive tzdata
RUN apt-get update \
&& apt-get install -y --no-install-recommends tzdata ca-certificates \
&& ln -snf "/usr/share/zoneinfo/$TZ" /etc/localtime \
&& echo "$TZ" > /etc/timezone \
&& dpkg-reconfigure --frontend noninteractive tzdata \
&& rm -rf /var/lib/apt/lists/*

WORKDIR /azerothcore

Expand Down Expand Up @@ -145,7 +145,7 @@ ENTRYPOINT ["/usr/bin/env", "bash", "/azerothcore/entrypoint.sh"]
###############

FROM runtime AS authserver
LABEL description "AzerothCore Auth Server"
LABEL description="AzerothCore Auth Server"

ENV ACORE_COMPONENT=authserver
# Don't run database migrations. We can leave that up to the db-import container
Expand All @@ -167,7 +167,7 @@ CMD ["authserver"]

FROM runtime AS worldserver

LABEL description "AzerothCore World Server"
LABEL description="AzerothCore World Server"

ENV ACORE_COMPONENT=worldserver
# Don't run database migrations. We can leave that up to the db-import container
Expand All @@ -190,7 +190,7 @@ CMD ["worldserver"]

FROM runtime AS db-import

LABEL description "AzerothCore Database Import tool"
LABEL description="AzerothCore Database Import tool"

USER $DOCKER_USER

Expand All @@ -203,7 +203,7 @@ COPY --chown=$DOCKER_USER:$DOCKER_USER\
--from=build \
/azerothcore/env/dist/bin/dbimport /azerothcore/env/dist/bin/dbimport

CMD /azerothcore/env/dist/bin/dbimport
CMD [ "/azerothcore/env/dist/bin/dbimport" ]

###############
# Client Data #
Expand All @@ -225,15 +225,15 @@ VOLUME /azerothcore/env/dist/data

USER $DOCKER_USER

CMD bash -c "source /azerothcore/apps/installer/includes/functions.sh && inst_download_client_data"
CMD ["bash", "-c", "source /azerothcore/apps/installer/includes/functions.sh && inst_download_client_data" ]

##################
# Map Extractors #
##################

FROM runtime AS tools

LABEL description "AzerothCore Tools"
LABEL description="AzerothCore Tools"

WORKDIR /azerothcore/env/dist/

Expand Down

0 comments on commit af1a6f3

Please sign in to comment.