fix(Core/Player): SpellQueue avoid possible undefined behavior by cop…

…ying instead of move (azerothcore#21444)
sudlud · Feb 14, 2025 · 75441dd · 75441dd
1 parent 3854d00
commit 75441dd
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/server/game/Handlers/SpellHandler.cpp b/src/server/game/Handlers/SpellHandler.cpp
@@ -110,11 +110,12 @@ void WorldSession::HandleUseItemOpcode(WorldPacket& recvPacket)
     if (!_player->CanExecutePendingSpellCastRequest(spellInfo))
         if (_player->CanRequestSpellCast(spellInfo))
         {
-            recvPacket.rpos(0); // Reset read position to the start of the buffer.
+            WorldPacket packetCopy(recvPacket); // Copy the packet
+            packetCopy.rpos(0); // Reset read position to the start of the buffer.
             _player->SpellQueue.emplace_back(
                 spellId,
                 spellInfo->GetCategory(),
-                std::move(recvPacket), // Move ownership of recvPacket
+                std::move(packetCopy), // Move ownership of copied packet
                 true // itemCast
             );
             return;
@@ -424,11 +425,12 @@ void WorldSession::HandleCastSpellOpcode(WorldPacket& recvPacket)
     {
         if (_player->CanRequestSpellCast(spellInfo))
         {
-            recvPacket.rpos(0); // Reset read position to the start of the buffer.
+            WorldPacket packetCopy(recvPacket); // Copy the packet
+            packetCopy.rpos(0); // Reset read position to the start of the buffer.
             _player->SpellQueue.emplace_back(
                 spellId,
                 spellInfo->GetCategory(),
-                std::move(recvPacket) // Move ownership of recvPacket
+                std::move(packetCopy) // Move ownership of copied packet
             );
             return;
         }