Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make the witnesses wrapper with flex-wrap css prop #517

Merged
merged 3 commits into from
Nov 6, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: use inline-flex for witnesses wrapper to be in text flow
orlinmalkja committed Nov 5, 2024
commit 272bfa73be678e804188cdc1867b17ec2268f1a3
2 changes: 1 addition & 1 deletion src/utils/annotations.js
Original file line number Diff line number Diff line change
@@ -272,7 +272,7 @@ export function addWitness(target, witness, color) {

function createWitnessesWrapper() {
const el = document.createElement("span");
el.classList.add('witnesses', 't-flex', 't-flex-wrap')
el.classList.add('witnesses', 't-inline-flex', 't-flex-wrap')

return el
}

Unchanged files with check annotations Beta

import { domParser, delay } from '@/utils';
const props = defineProps({
url: String,

Check warning on line 38 in src/components/ContentView.vue

GitHub Actions / build (18)

Prop 'url' requires default value to be set

Check warning on line 38 in src/components/ContentView.vue

GitHub Actions / build (20)

Prop 'url' requires default value to be set
type: String,

Check warning on line 39 in src/components/ContentView.vue

GitHub Actions / build (18)

Prop 'type' requires default value to be set

Check warning on line 39 in src/components/ContentView.vue

GitHub Actions / build (20)

Prop 'type' requires default value to be set
fontSize: Number,

Check warning on line 40 in src/components/ContentView.vue

GitHub Actions / build (18)

Prop 'fontSize' requires default value to be set

Check warning on line 40 in src/components/ContentView.vue

GitHub Actions / build (20)

Prop 'fontSize' requires default value to be set
});
const emit = defineEmits(['loading']);
<script setup>
defineProps({
background: String,

Check warning on line 37 in src/components/LoadingSpinner.vue

GitHub Actions / build (18)

Prop 'background' requires default value to be set

Check warning on line 37 in src/components/LoadingSpinner.vue

GitHub Actions / build (20)

Prop 'background' requires default value to be set
});
</script>
type: String,
default: () => '',
},
title: String,

Check warning on line 31 in src/components/MessageBox.vue

GitHub Actions / build (18)

Prop 'title' requires default value to be set

Check warning on line 31 in src/components/MessageBox.vue

GitHub Actions / build (20)

Prop 'title' requires default value to be set
type: {
type: String,
default: () => '',
<p>{{ activeVariantsGroupedByTarget[selector].content }}</p>
</div>
<div
v-for="(variant, i) in activeVariantsGroupedByTarget[selector].variants"

Check warning on line 54 in src/components/annotations/variants/ActiveVariantsDetails.vue

GitHub Actions / build (18)

Variable 'i' is already declared in the upper scope

Check warning on line 54 in src/components/annotations/variants/ActiveVariantsDetails.vue

GitHub Actions / build (20)

Variable 'i' is already declared in the upper scope
:key="i"
class="t-border t-rounded-md t-min-w-[16rem] t-p-4"
>
v-html="entry"
/>
</div>
<hr class="t-slate-200 t-my-[6px] t-rounded-none" v-if="showSeparator" data-cy="variant-sep-line"/>

Check warning on line 28 in src/components/annotations/variants/VariantItem.vue

GitHub Actions / build (18)

Disallow self-closing on HTML void elements (<hr/>)

Check warning on line 28 in src/components/annotations/variants/VariantItem.vue

GitHub Actions / build (18)

Attribute "v-if" should go before "class"

Check warning on line 28 in src/components/annotations/variants/VariantItem.vue

GitHub Actions / build (18)

'v-if' should be on a new line

Check warning on line 28 in src/components/annotations/variants/VariantItem.vue

GitHub Actions / build (18)

'data-cy' should be on a new line

Check warning on line 28 in src/components/annotations/variants/VariantItem.vue

GitHub Actions / build (20)

Disallow self-closing on HTML void elements (<hr/>)

Check warning on line 28 in src/components/annotations/variants/VariantItem.vue

GitHub Actions / build (20)

Attribute "v-if" should go before "class"

Check warning on line 28 in src/components/annotations/variants/VariantItem.vue

GitHub Actions / build (20)

'v-if' should be on a new line

Check warning on line 28 in src/components/annotations/variants/VariantItem.vue

GitHub Actions / build (20)

'data-cy' should be on a new line
</template>
<script setup lang="ts">