Display all collectors' names and add a test for this #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulpestov
reviewed
Sep 17, 2024
| if (collection.collector.length === 1) return [collection.collector[0].name]; | ||
|
|
||
| let collectors: string[] = [] | ||
| collection.collector.forEach((collector) => { |
There was a problem hiding this comment.
To simplify this, you could use .map function. Also the return type should stay the same (string). This can be achieved by using .join(', ')after map with an inline return. Please pay attention to the space after comma.
|
thanks for your comment! I fixed it, so please continue with your review. |
paulpestov
approved these changes
Sep 18, 2024
orlinmalkja
added a commit
that referenced
this pull request
Oct 8, 2024
* chore: change the ahiqar arabic local karshuni file * fix: display all collectors'names in metadata * test: add a test for showing all collectors names * chore: restore the file as it was before this PR * refactor: write in a more compact way the function getCollectorName() --------- Co-authored-by: malkja <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #471