Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests errors and hide the variants details button when no variant item is selected #463

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Fix tests errors and hide the variants details button when no variant item is selected #463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
751c856
test: change the id of select all button
Sep 6, 2024
21645d6
fix: hide variants details button when no v.item is selected
Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/annotations/variants/VariantsTopBar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
@click="witnessesDetailsDialogOpen = true"
/>
</div>
<div class="t-mt-4 t-flex t-items-center">
<div class="t-mt-4 t-flex t-items-center" v-show="Object.keys(annotationsStore.activeAnnotations).length > 0">

Check warning on line 80 in src/components/annotations/variants/VariantsTopBar.vue

View workflow job for this annotation

GitHub Actions / build (18) 

Attribute "v-show" should go before "class"

Check warning on line 80 in src/components/annotations/variants/VariantsTopBar.vue

View workflow job for this annotation

GitHub Actions / build (18) 

'v-show' should be on a new line

Check warning on line 80 in src/components/annotations/variants/VariantsTopBar.vue

View workflow job for this annotation

GitHub Actions / build (20) 

Attribute "v-show" should go before "class"

Check warning on line 80 in src/components/annotations/variants/VariantsTopBar.vue

View workflow job for this annotation

GitHub Actions / build (20) 

'v-show' should be on a new line
<span class="t-text-sm t-font-bold">{{ Object.keys(annotationsStore.activeAnnotations).length }} Variants selected</span>
<BaseButton
class="t-ml-auto"
Expand Down
2 changes: 1 addition & 1 deletion tests/cypress/e2e/annotation.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const ahiqarSelectors = {
listOfSecondTab: '.panels-wrapper > .panel:nth-child(4) [role="tabpanel"]:nth-child(2) .annotations-list',
tab: '.panels-wrapper > .panel:nth-child(4) [role="tablist"] [data-pc-section="nav"] [data-pc-name="tabpanel"]',
text: '.panels-wrapper > .panel:nth-child(3) #text-content',
annotationPanelActionCheckbox: '.panel-header .actions > div:first-child #panel-toggle-action',
annotationPanelActionCheckbox: '.panel-header .actions > div:first-child #panel-check-action',
}

const gflSelectors = {
Expand Down
Loading