Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish 2. point of roadmap: variants list (variants selection) #457

Closed
wants to merge 15 commits into from

Conversation

orlinmalkja
Copy link
Contributor

No description provided.

@orlinmalkja orlinmalkja changed the title Finish variants list and top bar Finish 2. point of roadmap: variants list (variants selection) Jul 26, 2024
@orlinmalkja orlinmalkja requested a review from paulpestov July 26, 2024 14:56
Copy link
Collaborator

@paulpestov paulpestov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some things adresss here:

  • Please refer to the video in the ticket Roadmap about Implementation of the Variants in Annotations Panel #261 which shows a mock-up of the variants list and try to stick to the overall design idea. Improvement suggestions:
    • remove table-like headlines, align things inside an item to the left
    • smaller size of the "chip", more rounded, outlined without background
    • reproduce the same chip design when adding an element in the text panel
    • fix dark mode styles
  • I am confused by the fact that we see 3 clickable variant items where on click you get 4 "pairs" selected at once. In the mock-up they always have only 1 witness identifier next to the entry. So if I assume right, the task should be to split up each of those 3 items into 4 individual items, so each witness/entry pair becomes clickable. The 4 "pairs" still refer to the same text panel element, though. So it is only possible to inspect only 1 witness/entry at a time in the text panel. But maybe there is still a general misunderstanding of the data @mathias-goebel.

src/stores/annotations.ts Outdated Show resolved Hide resolved
src/stores/annotations.ts Outdated Show resolved Hide resolved
src/utils/annotations.js Outdated Show resolved Hide resolved
@paulpestov
Copy link
Collaborator

Also please chnge the icon names in the config and run npm run fix before submitting a PR. We need to bring that command to Github actions btw.

malkja added 11 commits July 31, 2024 10:48
smaller size of the "chip", more rounded, outlined without a background
add border color for each of the different 'chips' and reproduce the same chips design when adding a chip in the text panel
split up the variant items to make each of them clickable
when clicking on a witness chip in the Top bar we show/hide the variant items which are witnessed by this witness
@paulpestov paulpestov closed this Aug 8, 2024
@paulpestov paulpestov deleted the finish-variants-list-and-top-bar branch October 18, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants