-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish 2. point of roadmap: variants list (variants selection) #457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion or the annotated text
orlinmalkja
changed the title
Finish variants list and top bar
Finish 2. point of roadmap: variants list (variants selection)
Jul 26, 2024
paulpestov
requested changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some things adresss here:
- Please refer to the video in the ticket Roadmap about Implementation of the Variants in Annotations Panel #261 which shows a mock-up of the variants list and try to stick to the overall design idea. Improvement suggestions:
- remove table-like headlines, align things inside an item to the left
- smaller size of the "chip", more rounded, outlined without background
- reproduce the same chip design when adding an element in the text panel
- fix dark mode styles
- I am confused by the fact that we see 3 clickable variant items where on click you get 4 "pairs" selected at once. In the mock-up they always have only 1 witness identifier next to the entry. So if I assume right, the task should be to split up each of those 3 items into 4 individual items, so each witness/entry pair becomes clickable. The 4 "pairs" still refer to the same text panel element, though. So it is only possible to inspect only 1 witness/entry at a time in the text panel. But maybe there is still a general misunderstanding of the data @mathias-goebel.
Also please chnge the icon names in the config and run |
smaller size of the "chip", more rounded, outlined without a background
add border color for each of the different 'chips' and reproduce the same chips design when adding a chip in the text panel
split up the variant items to make each of them clickable
when clicking on a witness chip in the Top bar we show/hide the variant items which are witnessed by this witness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.