Standalone CLI: sub #232

nstogner · 2023-09-06T01:39:16Z

Add a standalone CLI: sub

Replaces the current kubectl plugins.

Makefile

api/v1/model_types.go

samos123 · 2023-09-06T05:15:28Z

docs/cli.md

+## List
+
+```bash
+strat ls (list)


+1 to strat, -1 to ai

I think sub has my preference right now

docs/cli.md

docs/container-contract.md

docs/design.md

samos123 · 2023-09-06T05:23:25Z

install/gcp/up.sh

-  --max-cpu 960 --max-memory 9600 --ephemeral-storage-local-ssd=count=2 \
-  --autoprovisioning-scopes=logging.write,monitoring,devstorage.read_only,compute \
-  --addons GcsFuseCsiDriver
+	gcloud container clusters create ${CLUSTER_NAME} --location ${REGION} \


this messes up the docs rendering so would prefer original formatting instead of spaces at beginning of lines

Editor side-effect, reverted

samos123 · 2023-09-06T05:31:04Z

Overall the CLI looks promising! Can't wait to try it out for my dev flow.

I would prefer to keep this PR only to what's needed to make the Standalone CLI work. Any refactors should be done as separate PRs and discussed separately. Things like reformatting the gcp install scripts or renaming baseModel to model are big changes that don't seem to be required for the standalone CLI.

samos123 · 2023-09-09T16:20:40Z

docs/container-contract.md

-  data/           # Location where Datasets will be mounted (reading and loading).
+  data/           # Location where a previously stored Datasets is mounted.
+  model/          # Location where a previously stored Model is mounted.
+  output/         # Location to store output of a run.


change to `artifacts

samos123 · 2023-09-09T16:21:14Z

docs/design.md

@@ -127,7 +125,6 @@ The example Model's backing storage would end up being:

 ```sh
 gs://abc123-substratus-artifacts/f94a0d128bcbd9c1b824e9e5572baf86/model/


I think there is no longer a good reason to store model in a subdirectory

agreed, I think this doc is wrong now, will fix

samos123 · 2023-09-09T16:22:34Z

install/gcp/up.sh

please revert all changes in this file unless these changes were needed to fix something

will do before merge

install/gcp/up.sh

samos123 · 2023-09-10T04:35:04Z

Edit: Ignore this is already fixed in commit 47c4a76

I noticed the following log:

2023/09/09 21:34:03 Pod logs for: %v: %v test-gguf-model-notebook-bld-n85wk time="2023-09-10T04:34:03Z" level=info msg="Retrieving image nvidia/cuda:12.2.0-devel-ubuntu22.04 from registry index.docker.io"

samos123 · 2023-09-10T04:54:22Z

Not for this PR, but something to discuss as a follow up. One thing that was rather annoying was being unable to edit params.json from within the notebook. It's mounted as read-only. I noticed I had a typo in my param.json and my only way to solve it was to delete the notebook and modify the substratus resource.

samos123 · 2023-09-10T05:03:47Z

I can't seem to get out once I hit an error, Ctrl + C and Q are both not working:

samos123 · 2023-09-10T05:18:27Z

file syncing currently only happens for files in src directory. I placed my notebook in the main directory. I think the file sync should happen for any .ipynb file that's also in the local directory.

…e and serve cmds

samos123 · 2023-09-26T04:58:10Z

docs/cli.md

+## Substratus.yaml
+
+### Option 1: Workspace file
+


workspace file seems complex, having multiple files feels cleaner

samos123 · 2023-09-26T04:58:42Z

docs/cli.md

+
+**Cons:**
+
+* Could get messy


and complex if you never used kustomize

samos123 · 2023-09-26T04:59:35Z

docs/cli.md

+  # Generated if not specified
+```
+
+### Option 2: Multi-doc


I think this or simply creating multiple files within same dir is better

samos123 · 2023-09-26T05:03:58Z

containertools/cmd/nbwatch/main.go

-	w.Add("/content/src")
+	const contentDir = "/content"
+
+	// NOTE: Watch is non-recursive.


so it would watch /content/src but not /content/src/my-dir/sam.ipynb?

samos123 · 2023-09-26T05:09:15Z

internal/controller/dataset_controller.go

 		Mounts: []cloud.BucketMount{
-			{BucketSubdir: "data", ContentSubdir: "data"},
-			{BucketSubdir: "logs", ContentSubdir: "logs"},
+			{BucketSubdir: "artifacts", ContentSubdir: "artifacts"},


Do we still need a BucketSubdir now that it is all artifacts together? I think probably cleaner to remove it

I dont think we need it anymore

Will leave for later refactor

internal/tui/manifests.go

samos123 · 2023-09-30T06:32:12Z

internal/cli/push.go

+	}
+
+	cmd := &cobra.Command{
+		Use:   "push [dir]",


I'm fine with push as well but feel run is more descriptive of what the end-result is here. The pushing is just an intermediary step to run it.

Updated to run

nstogner · 2023-09-30T22:51:30Z

Tracking the param.json issue here: #237