Support for local kind cluster #190
Conversation
| if _, err := io.Copy(f, r); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Reaching a bit here but is it better to os.Stat(dst) the destination before copying so as to not overwrite?
There was a problem hiding this comment.
I think overwriting the stored tarball is what we do in the real buckets today
There was a problem hiding this comment.
overwriting the stored tarball is what we do in the real buckets today
Huh - I bet we have a not-so-subtle bug on GCP where one user could easily overwrite another's before the builder can start a build against it. LMK if I'm thinking about that wrong. If not, I'll create an issue.
There was a problem hiding this comment.
Are you thinking two users could both be running kubectl notebook -d . on the same Notebook at the same time?
There was a problem hiding this comment.
If so, we are not currently accounting for that. Notebooks are intended to be used by 1 user at a time at the moment.
nstogner
changed the title
Makefile
Outdated
| @@ -257,7 +283,8 @@ installation-scripts: | |||
| installation-manifests: manifests kustomize | |||
| cd config/manager && $(KUSTOMIZE) edit set image controller=${IMG} | |||
| cd config/gcpmanager && $(KUSTOMIZE) edit set image gcp-manager=${IMG_GCPMANAGER} | |||
| $(KUSTOMIZE) build config/default > install/kubernetes/system.yaml | |||
| $(KUSTOMIZE) build config/install-gcp > install/kubernetes/system.yaml | |||
There was a problem hiding this comment.
I can change this to install/kubernetes/gcp/system.yaml in my PR or you can do it here
There was a problem hiding this comment.
Lets merge your PR 1st
There was a problem hiding this comment.
I am now in favor of merging my PR first. I tested it very thoroughly and feel it's ready. Let's discuss more offline.
There was a problem hiding this comment.
Yeah it's become necessary at this point. I don't think we'll end up in this state in the future (developing multiple SCIs at once) but I think we can avoid this if we worked in smaller chunks as PRs (SCI -> SCI implementation -> deployment bits -> lastly the controller integration). The last piece would be the only part blocked by unfinished-implementations.
| @@ -0,0 +1,12 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
I think this should be included by default in all installation not just kind?
There was a problem hiding this comment.
I have done this in my PR/branch for now as well: 01d2ec1
Approach I took is add namespace.yaml under config/manager. I thought it wasn't worth creating a separate directory.
nstogner
force-pushed
the
kind
branch
2 times, most recently
from
de0af1b
to
33095d7
Compare
| fi | ||
| nsenter --target 1 --mount bash -c "systemctl is-active --quiet containerd && echo 'Restarting containerd' && systemctl restart containerd" | ||
| # Wait for containerd to be ready so that skaffold doesn't fail. | ||
| nsenter --target 1 --mount bash -c "while ! ctr -n k8s.io containers ls; do sleep 1; done" |
Add local kind support.
See Diagram
Fixes #152