fix #232 secret token empty validation error (#233)

Some users have reported validation issues with a secret that has an empty string as value.
substratusai · Sep 22, 2024 · a1ec759 · a1ec759
1 parent 12f5e4f
commit a1ec759
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/charts/kubeai/templates/secret.yaml b/charts/kubeai/templates/secret.yaml
@@ -1,4 +1,6 @@
-{{- if .Values.secrets.huggingface.create -}}
+# Only create the secret if the token is not empty.
+# See: https://github.com/substratusai/kubeai/issues/232
+{{- if and .Values.secrets.huggingface.create (not (empty .Values.secrets.huggingface.token)) -}}
 apiVersion: v1
 kind: Secret
 metadata:

diff --git a/internal/modelcontroller/model_controller.go b/internal/modelcontroller/model_controller.go
@@ -225,7 +225,8 @@ func (r *ModelReconciler) vLLMPodForModel(m *kubeaiv1.Model, profile ModelConfig
 					LocalObjectReference: corev1.LocalObjectReference{
 						Name: r.HuggingfaceSecretName,
 					},
-					Key: "token",
+					Key:      "token",
+					Optional: ptr.To(true),
 				},
 			},
 		},