feat: implement Plan.expected_type_urls field
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds support for the `expected_type_urls` field of the `Plan` message. This is pretty straight-forward: the repeated field of string becomes an `ArrayAttr` of `StringAttr`s. We don't really need this field currently but it's the last missing field of the `Plan` message, so it allows us to tick that message type off. Signed-off-by: Ingo Müller <[email protected]>
ingomueller-net
force-pushed
the
expected-type-urls
branch
from
66c3012 to
948922c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
expected_type_urlsfield of thePlanmessage. This is pretty straight-forward: the repeated field of string becomes anArrayAttrofStringAttrs. We don't really need this field currently but it's the last missing field of thePlanmessage, so it allows us to tick that message type off.