ci: run pyright as part of CI and fix issues it found #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingomueller-net
force-pushed
the
ci-pyright
branch
11 times, most recently
from
d1353a8 to
04b8fe2
Compare
|
(Finally working as intended now and ready for review.) |
|
|
jpienaar
reviewed
Dec 6, 2024
| @@ -49,7 +49,7 @@ def testNamedTable(): | |||
| pb_plan = ss.to_binpb(plan.operation).encode() | |||
|
|
|||
| # Execute in duckdb and print result. | |||
| query_result = con.from_substrait(proto=pb_plan) | |||
| query_result = con.from_substrait(proto=pb_plan) # type: ignore | |||
jpienaar
approved these changes
Dec 6, 2024
Signed-off-by: Ingo Müller <[email protected]>
This commit fixes some problems found by `pyright`: * In the DuckDB test, a `bytes` parameter is wrongly annotated as `str` in the stub files of that Python module. We silence that false positive with a suppression. * In the test for converting MLIR ops to plans, we use some op-specific members on an object whose most narrow known type is `MlirOperation`, so the commit adds a `cast` to make the `typing` information more precise.
Signed-off-by: Ingo Müller <[email protected]>
ingomueller-net
force-pushed
the
ci-pyright
branch
from
3641e71 to
e4a0470
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR runs
pyrightas part of CI and fixes some problems it found:strSubstrait plan tobyteseven though the parameter expects a
str, so the commit removes theconversion.
members on an object whose most narrow known type is
MlirOperation,so the commit adds a
castto make thetypinginformation moreprecise.
I have also tried to set up
pytestbut couldn't make it find all paths.