fix(spark): output columns of expand relation #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrew-coleman ah this has a conflict in the tests it enables, mind merging/rebasing main in? :) |
Fix the logic for deriving whether each output column of the expand relation is nullable or not. If one or more of the projections can assign null to the column, then it must be defined as nullable. Signed-off-by: Andrew Coleman <[email protected]> # Conflicts: # spark/src/test/scala/io/substrait/spark/TPCDSPlan.scala
andrew-coleman
force-pushed
the
fix_expand
branch
from
678681a
to
1d0a420
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the logic for deriving whether each output column of the expand relation is nullable or not.
If one or more of the projections can assign null to the column, then it must be defined as nullable.