-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automation promote from staging to maven central #104
feat: automation promote from staging to maven central #104
Conversation
Co-authored-by: Weston Pace <[email protected]>
Please confirm if 14 days is enough to promote a package from Staging to Production (Maven Central). |
I think this should happen instantly (as part of release). If we're doing automated releases, let's do automated releases... |
I will see these scenarios/options: 1. Scenario / Option: Merge PR on main brach --> after 7 days --> Release to Staging --> after 0 days --> Release to Maven Central Disadvantages:
Changes needed:
2. Scenario / Option: Merge PR on main brach --> after 0 days --> Release to Staging --> after 20 days --> Release to Maven Central Advantage:
Disadvantages:
Changes needed:
|
@davisusanibar, I prefer the first scenario you outlined. From my pov, the second scenario isn't really CD/automated releases. If we did want to do manual testing, I would expect that we would trigger the release directly after manual testing--not do manual testing and then wait a bunch more days before the code is released to others. I don't really see any benefit to a 20-day waiting period.
A major goal of automated releases is automated tests. We release when our tests say things are good. If the tests are failing, we shouldn't release. |
Ok, I agree. Let me close this PR and send another to implement escenario 1. |
This PR contains:
Third part to solve #43 , please complete review/merge #102 that is needed by this PR