ignore STOP debug frame #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldargab
requested changes
Sep 26, 2023
| @@ -398,6 +398,9 @@ function* mapDebugFrame(transactionIndex: number, debugFrameResult: rpc.DebugFra | |||
| } | |||
| } | |||
| break | |||
| case 'STOP': | |||
There was a problem hiding this comment.
Here we have a possibility of
- gaps in trace indexes/addresses
- children with no parent
if STOP will turn out to be not the last frame in transaction or to have children.
Thus, it is better to ignore it on traversal.
There was a problem hiding this comment.
my assumption was that if STOP frame is presented then it's a single frame without parents/children.
i checked several STOP frames from three networks (base, optimism, zora) and all the time it was a single frame
There was a problem hiding this comment.
i checked several STOP frames from three networks (base, optimism, zora) and all the time it was a single frame
Then, you have to make the assumption explicit by asserting it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.