feat: implement dump metrics #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldargab
requested changes
Sep 22, 2023
eldargab
reviewed
Sep 23, 2023
Done |
|
Added rpc requests metrics |
eldargab
requested changes
Sep 26, 2023
eldargab
requested changes
Sep 27, 2023
| to: assertNotNull(lastBlock) | ||
| } | ||
| const chunk = getNextChunk(blockRange.from, blockRange.to) | ||
| chunk.transactDir('.', async fs => { |
| }); | ||
|
|
||
| this.rpcRequestsGauge = new Gauge({ | ||
| name: 'sqd_rpc_requests_count', |
There was a problem hiding this comment.
General pattern for metric names in the SDK is sqd_{app}_{name}.
Since there could be multiple RPC connections used from a single process, url label should be added as well.
There was a problem hiding this comment.
I see currently only one url. But ok, will add this
eldargab
reviewed
Sep 27, 2023
| collect() { | ||
| const metrics = rpc.getMetrics(); | ||
| this.set({ | ||
| kind: 'successful', |
There was a problem hiding this comment.
May be success | failure instead of successful | failed? Sounds better to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.