Headers encryption implementation #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalabukdima
reviewed
Oct 25, 2024
| struct EncryptedHeaders { | ||
| identity: Vec<u8>, | ||
| nonce: Vec<u8>, | ||
| ciphertext: Vec<u8>, |
There was a problem hiding this comment.
Can we make it a map of name: encrypted_value instead and encrypt both with the same key and nonce? Parsing with serde_json is very expensive, so it's better to avoid it where possible.
| Err(_) => { | ||
| return None; | ||
| } | ||
| let EncryptedHeaders {identity, nonce, ciphertext,} = local_assignment.encrypted_headers.clone(); |
There was a problem hiding this comment.
It looks like it can be a reference instead of a clone
| @@ -154,15 +177,34 @@ impl Assignment { | |||
| } | |||
|
|
|||
| pub fn regenerate_headers(&mut self, cloudflare_storage_secret: String) { | |||
| let alice_secret_key = SecretKey::generate(&mut OsRng); | |||
There was a problem hiding this comment.
Let's just call it temp key and worker key before committing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.