feat(crypto): enabled the use of certificate/key pairs from disk vs. … #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…just using letsencrypt - issue#20
gavinelder
reviewed
May 23, 2020
jack1902
suggested changes
May 23, 2020
There was a problem hiding this comment.
LGTM, just need to remove the os.Exit calls after a log.Fatal https://golang.org/src/log/log.go?s=10156:10184#L320
gavinelder
reviewed
May 23, 2020
main.go
Outdated
| // Plain text web server for use behind a reverse proxy. | ||
| if !letsencrypt { | ||
| if !letsencrypt && tlsCertificate == "" || tlsKey == "" { |
There was a problem hiding this comment.
Suggested change
| if !letsencrypt && tlsCertificate == "" || tlsKey == "" { | |
| if !letsencrypt || tlsCertificate == "" || tlsKey == "" { |
There was a problem hiding this comment.
when:
le == false
kp == true
(!le || kp) then pass (which we don't want, correct?)
when:
le == false
kp == true
(!le && cert) then fail (which is what we want, no?)
So it should stay a && and not be changed to a || - or am I missing it?
main.go
Outdated
Comment on lines
344
to
351
| httpsd := &http.Server{ | ||
| Handler: r, | ||
| Addr: httpAddr, | ||
| WriteTimeout: httpTimeout, | ||
| ReadTimeout: httpTimeout, | ||
| MaxHeaderBytes: maxHeaderBytes, | ||
| } | ||
|
|
There was a problem hiding this comment.
I need to check out the PR on my own machine but this looks like it's in the wrong place.
|
It's been a few days - any other issues which need be resolved before merging? |
|
Is there a possibility this might get merged soon? |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enabled the use of certificate/key pairs from disk vs. just using let's encrypt - issue#20
to:
cc: @subspacecommunity/subspace-maintainers
related to:
resolves: #20
Background
Requested in #20
Changes
Testing
Steps for how this change was tested and verified
Generate a certificate/key pair in PEM format and try it out on the command line: