Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

private-key-cron-21: sample cronjob #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gilesw
Copy link

@gilesw gilesw commented May 22, 2020

Basic mitigation for storing the private keys on the server. Referenced in this ticket:-

#21

@gavinelder
Copy link

Honestly I think the use of Cron here could lead to a race condition and potential corruption of the config as a whole so it's probably best avoided.

@gavinelder
Copy link

Looking at the code and placing a defer on the add profile to not store the private key after download is probably best.

So as part of the add device they automatically get the file downloaded then clean up the key what's your thoughts on this ?

@gilesw
Copy link
Author

gilesw commented May 27, 2020

@gavinelder I'm running this at the moment no problem. You could change it to a find command so it never touches new files but I didn't think it was worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants