fix missing filter codeId in long type #262
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Background: cosmosjs deprecated long for message.callId in 0.32.0 https://github.com/cosmos/cosmjs/blob/main/CHANGELOG.md#changed-2. We made change to remove it in previous pr ac68f61#diff-7ed3b4e1e7a4809a4c839b761afb2eb1a0c45c6b5dd0f01c9cdb520cb80a015bL78.
From v3.11.0, We now facing any issue message filter not able to filter callId and handlers are not triggered.
In this fix, we temp bring back
long
for message.callId, due to we have multiple version of@cosmjs/stargate
installed in our sdk, and older version were installed from dependency@kyvejs/xxx
. Use resolution in package.json also could not fixed version for@cosmjs/stargate
.Fixes # (issue)
We shall remove
long
again once@kyvejs/xxx
update dependencies@cosmjs/stargate
to 0.32.0 or above.Type of change
Please delete options that are not relevant.
Checklist