Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update telescope with windows pathing fix #226

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Conversation

bz888
Copy link
Contributor

@bz888 bz888 commented Feb 2, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

Copy link

github-actions bot commented Feb 2, 2024

Coverage report

❌ An unexpected error occurred. For more details, check console

Error: The process '/usr/local/bin/yarn' failed with exit code 1
St.
Category Percentage Covered / Total
🔴 Statements 12.31% 568/4613
🔴 Branches 43.82% 39/89
🔴 Functions 13.41% 11/82
🔴 Lines 12.31% 568/4613

Test suite run failed

Failed tests: 0/7. Failed suites: 5/6.
  ● Test suite failed to run

    Cannot find module '@cosmology/ast' from 'node_modules/@subql/x-cosmology-proto-parser/main/traverse.js'

    Require stack:
      node_modules/@subql/x-cosmology-proto-parser/main/traverse.js
      node_modules/@subql/x-cosmology-proto-parser/main/store.js
      node_modules/@subql/x-cosmology-proto-parser/main/index.js
      node_modules/@subql/x-cosmology-telescope/main/builder.js
      node_modules/@subql/x-cosmology-telescope/main/index.js
      packages/common-cosmos/src/codegen/codegen-controller.ts
      packages/common-cosmos/src/codegen/codegen-controller.spec.ts

       7 | import {makeTempDir} from '@subql/common';
       8 | import {CosmosChaintypes, CustomModule, CosmosRuntimeDatasource} from '@subql/types-cosmos';
    >  9 | import telescope from '@subql/x-cosmology-telescope';
         | ^
      10 | import {Data} from 'ejs';
      11 | import {copySync} from 'fs-extra';
      12 | import {upperFirst} from 'lodash';

      at Resolver.resolveModule (node_modules/jest-resolve/build/resolver.js:324:11)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-proto-parser/main/traverse.js:4:15)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-proto-parser/main/store.js:12:20)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-proto-parser/main/index.js:22:14)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-telescope/main/builder.js:7:36)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-telescope/main/index.js:17:19)
      at Object.<anonymous> (packages/common-cosmos/src/codegen/codegen-controller.ts:9:1)
      at Object.<anonymous> (packages/common-cosmos/src/codegen/codegen-controller.spec.ts:12:1)


  ● Test suite failed to run

    Cannot find module '@cosmology/ast' from 'node_modules/@subql/x-cosmology-proto-parser/main/traverse.js'

    Require stack:
      node_modules/@subql/x-cosmology-proto-parser/main/traverse.js
      node_modules/@subql/x-cosmology-proto-parser/main/store.js
      node_modules/@subql/x-cosmology-proto-parser/main/index.js
      node_modules/@subql/x-cosmology-telescope/main/builder.js
      node_modules/@subql/x-cosmology-telescope/main/index.js
      packages/common-cosmos/src/codegen/codegen-controller.ts
      packages/common-cosmos/src/codegen/index.ts
      packages/common-cosmos/src/index.ts
      packages/node/src/configure/SubqueryProject.ts
      packages/node/src/indexer/api.service.ts
      packages/node/src/indexer/api.service.test.ts

       7 | import {makeTempDir} from '@subql/common';
       8 | import {CosmosChaintypes, CustomModule, CosmosRuntimeDatasource} from '@subql/types-cosmos';
    >  9 | import telescope from '@subql/x-cosmology-telescope';
         | ^
      10 | import {Data} from 'ejs';
      11 | import {copySync} from 'fs-extra';
      12 | import {upperFirst} from 'lodash';

      at Resolver.resolveModule (node_modules/jest-resolve/build/resolver.js:324:11)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-proto-parser/main/traverse.js:4:15)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-proto-parser/main/store.js:12:20)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-proto-parser/main/index.js:22:14)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-telescope/main/builder.js:7:36)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-telescope/main/index.js:17:19)
      at Object.<anonymous> (packages/common-cosmos/src/codegen/codegen-controller.ts:9:1)
      at Object.<anonymous> (packages/common-cosmos/src/codegen/index.ts:4:1)
      at Object.<anonymous> (packages/common-cosmos/src/index.ts:4:1)
      at Object.<anonymous> (packages/node/src/configure/SubqueryProject.ts:7:1)


  ● Test suite failed to run

    Cannot find module '@cosmology/ast' from 'node_modules/@subql/x-cosmology-proto-parser/main/traverse.js'

    Require stack:
      node_modules/@subql/x-cosmology-proto-parser/main/traverse.js
      node_modules/@subql/x-cosmology-proto-parser/main/store.js
      node_modules/@subql/x-cosmology-proto-parser/main/index.js
      node_modules/@subql/x-cosmology-telescope/main/builder.js
      node_modules/@subql/x-cosmology-telescope/main/index.js
      packages/common-cosmos/src/codegen/codegen-controller.ts
      packages/common-cosmos/src/codegen/index.ts
      packages/common-cosmos/src/index.ts
      packages/node/src/configure/SubqueryProject.ts
      packages/node/src/indexer/dictionary.service.ts
      packages/node/src/indexer/fetch.service.spec.ts

       7 | import {makeTempDir} from '@subql/common';
       8 | import {CosmosChaintypes, CustomModule, CosmosRuntimeDatasource} from '@subql/types-cosmos';
    >  9 | import telescope from '@subql/x-cosmology-telescope';
         | ^
      10 | import {Data} from 'ejs';
      11 | import {copySync} from 'fs-extra';
      12 | import {upperFirst} from 'lodash';

      at Resolver.resolveModule (node_modules/jest-resolve/build/resolver.js:324:11)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-proto-parser/main/traverse.js:4:15)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-proto-parser/main/store.js:12:20)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-proto-parser/main/index.js:22:14)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-telescope/main/builder.js:7:36)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-telescope/main/index.js:17:19)
      at Object.<anonymous> (packages/common-cosmos/src/codegen/codegen-controller.ts:9:1)
      at Object.<anonymous> (packages/common-cosmos/src/codegen/index.ts:4:1)
      at Object.<anonymous> (packages/common-cosmos/src/index.ts:4:1)
      at Object.<anonymous> (packages/node/src/configure/SubqueryProject.ts:7:1)


  ● Test suite failed to run

    Cannot find module '@cosmology/ast' from 'node_modules/@subql/x-cosmology-proto-parser/main/traverse.js'

    Require stack:
      node_modules/@subql/x-cosmology-proto-parser/main/traverse.js
      node_modules/@subql/x-cosmology-proto-parser/main/store.js
      node_modules/@subql/x-cosmology-proto-parser/main/index.js
      node_modules/@subql/x-cosmology-telescope/main/builder.js
      node_modules/@subql/x-cosmology-telescope/main/index.js
      packages/common-cosmos/src/codegen/codegen-controller.ts
      packages/common-cosmos/src/codegen/index.ts
      packages/common-cosmos/src/index.ts
      packages/node/src/configure/SubqueryProject.ts
      packages/node/src/indexer/api.service.ts
      packages/node/src/utils/cosmos.spec.ts

       7 | import {makeTempDir} from '@subql/common';
       8 | import {CosmosChaintypes, CustomModule, CosmosRuntimeDatasource} from '@subql/types-cosmos';
    >  9 | import telescope from '@subql/x-cosmology-telescope';
         | ^
      10 | import {Data} from 'ejs';
      11 | import {copySync} from 'fs-extra';
      12 | import {upperFirst} from 'lodash';

      at Resolver.resolveModule (node_modules/jest-resolve/build/resolver.js:324:11)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-proto-parser/main/traverse.js:4:15)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-proto-parser/main/store.js:12:20)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-proto-parser/main/index.js:22:14)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-telescope/main/builder.js:7:36)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-telescope/main/index.js:17:19)
      at Object.<anonymous> (packages/common-cosmos/src/codegen/codegen-controller.ts:9:1)
      at Object.<anonymous> (packages/common-cosmos/src/codegen/index.ts:4:1)
      at Object.<anonymous> (packages/common-cosmos/src/index.ts:4:1)
      at Object.<anonymous> (packages/node/src/configure/SubqueryProject.ts:7:1)


  ● Test suite failed to run

    Cannot find module '@cosmology/ast' from 'node_modules/@subql/x-cosmology-proto-parser/main/traverse.js'

    Require stack:
      node_modules/@subql/x-cosmology-proto-parser/main/traverse.js
      node_modules/@subql/x-cosmology-proto-parser/main/store.js
      node_modules/@subql/x-cosmology-proto-parser/main/index.js
      node_modules/@subql/x-cosmology-telescope/main/builder.js
      node_modules/@subql/x-cosmology-telescope/main/index.js
      packages/common-cosmos/src/codegen/codegen-controller.ts
      packages/common-cosmos/src/codegen/index.ts
      packages/common-cosmos/src/index.ts
      packages/node/src/configure/SubqueryProject.ts
      packages/node/src/indexer/dictionary.service.ts
      packages/node/src/indexer/dictionary.service.spec.ts

       7 | import {makeTempDir} from '@subql/common';
       8 | import {CosmosChaintypes, CustomModule, CosmosRuntimeDatasource} from '@subql/types-cosmos';
    >  9 | import telescope from '@subql/x-cosmology-telescope';
         | ^
      10 | import {Data} from 'ejs';
      11 | import {copySync} from 'fs-extra';
      12 | import {upperFirst} from 'lodash';

      at Resolver.resolveModule (node_modules/jest-resolve/build/resolver.js:324:11)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-proto-parser/main/traverse.js:4:15)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-proto-parser/main/store.js:12:20)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-proto-parser/main/index.js:22:14)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-telescope/main/builder.js:7:36)
      at Object.<anonymous> (node_modules/@subql/x-cosmology-telescope/main/index.js:17:19)
      at Object.<anonymous> (packages/common-cosmos/src/codegen/codegen-controller.ts:9:1)
      at Object.<anonymous> (packages/common-cosmos/src/codegen/index.ts:4:1)
      at Object.<anonymous> (packages/common-cosmos/src/index.ts:4:1)
      at Object.<anonymous> (packages/node/src/configure/SubqueryProject.ts:7:1)

Report generated by 🧪jest coverage report action from 4cc6be3

Comment on lines 8 to 9
### Changed
- Update `telescope` package with forked `telescope` that contains win pathing fix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Changed
- Update `telescope` package with forked `telescope` that contains win pathing fix
### Fixed
- Codegen failing on Windows by using forked version of `telescope` (#226)

@stwiname stwiname merged commit 3871fed into main Feb 2, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants