Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix websocket client adding /websocket to the end of urls #222

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

stwiname
Copy link
Contributor

Description

I'm unsure why this code was here in the first place.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

Copy link

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 37.3% 1721/4614
🟡 Branches 63.58% 96/151
🔴 Functions 19.25% 36/187
🔴 Lines 37.3% 1721/4614

Test suite run success

38 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from e95f2fb

@stwiname stwiname merged commit 995fac3 into main Jan 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants