patch encoding in tendermint 37 client #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stwiname
reviewed
Jan 22, 2024
| await prepareApiService(); | ||
| }); | ||
|
|
||
| it('chihuahua test, can query block result', async () => { |
There was a problem hiding this comment.
It would be good to have a comment with details about the specific issue we faced
Coverage report
Test suite run success39 tests passing in 6 suites. Report generated by 🧪jest coverage report action from 5862d35 |
stwiname
approved these changes
Jan 22, 2024
jiqiang90
added a commit
that referenced
this pull request
Jan 23, 2024
This reverts commit e241274.
jiqiang90
added a commit
that referenced
this pull request
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
This fix cosmos/cosmjs#1543 when we get block detail from Chihuahua block.
Patch been moved under node package, due to we are using mono repo, so when run locally postinstall patch will unable to find the correct
node_modulepath, but in npm package it should able to find the correct path and patch.Type of change
Please delete options that are not relevant.
Checklist