Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated code not building when conflicing names #216

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

stwiname
Copy link
Contributor

@stwiname stwiname commented Dec 12, 2023

Description

Fixes codegen generating an invalid CosmosMessageTypes.ts when different proto files have the same message names. To fix this the imports are updated to use * and the exported types are now wrapped in namespaces.

This PR also filters the types to only include RPC messages that are prefixed with Msg following the cosmos naming convention

Fixes #215

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

Copy link

github-actions bot commented Dec 12, 2023

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 37.23% 1721/4622
🟡 Branches 63.58% 96/151
🔴 Functions 19.25% 36/187
🔴 Lines 37.23% 1721/4622

Test suite run success

38 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from a4983ea

@stwiname stwiname merged commit 3350a95 into main Dec 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build issues from codegen
2 participants