Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indexing events multiple times #194

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Fix indexing events multiple times #194

merged 2 commits into from
Oct 30, 2023

Conversation

stwiname
Copy link
Contributor

@stwiname stwiname commented Oct 30, 2023

Description

Fix events being potentially indexed multiple times because of message indexes being within a transaction not a block
Fix testing not working because of missing dependencies

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 34.17% 1665/4873
🟡 Branches 62.68% 89/142
🔴 Functions 17.39% 32/184
🔴 Lines 34.17% 1665/4873

Test suite run success

36 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from e49026b

@stwiname stwiname merged commit c4f6cb5 into main Oct 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants