Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix RuntimeDatasourceTemplate generic typing #182

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Conversation

bz888
Copy link
Contributor

@bz888 bz888 commented Oct 4, 2023

Description

Fix typing for RuntimeDatasourceTemplate

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 34.89% 1683/4824
🟡 Branches 62.5% 85/136
🔴 Functions 17.49% 32/183
🔴 Lines 34.89% 1683/4824

Test suite run success

32 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from 747abaa

@bz888 bz888 merged commit 897a280 into main Oct 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants