Adjust golangci-lint linters #3284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new linters (some commented out if not needed) and removed deprecated linters. Related to submariner-io/enhancements#231 Signed-off-by: Tom Pantelis <[email protected]>
"Error return value of `encoding/json.MarshalIndent` is not checked" Signed-off-by: Tom Pantelis <[email protected]>
"interface method <...> must have named param for type <...>" Signed-off-by: Tom Pantelis <[email protected]>
- "fmt.Errorf can be replaced with errors.New" - "fmt.Sprintf can be replaced with string concatenation" - "fmt.Sprint can be replaced with faster strconv.FormatUint" - "fmt.Sprintf can be replaced with faster strconv.Itoa" Signed-off-by: Tom Pantelis <[email protected]>
"Function name: testReconciliation, Cyclomatic Complexity: 2, Halstead Volume: 13318.79, Maintainability Index: 14" Refactored testReconciliation into several functions to alleviate the complexity. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
requested review from
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr3284/tpantelis/adj_linters |
skitt
approved these changes
Nov 28, 2024
dfarrell07
approved these changes
Dec 2, 2024
|
🤖 Closed branches: [z_pr3284/tpantelis/adj_linters] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new linters (some commented out if not needed) and removed deprecated linters. Also addressed violations reported by new linters (in separate commits).
Related to submariner-io/enhancements#231