Improve podCIDR detection #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sridhargaddam
requested review from
Oats87,
skitt and
tpantelis
as code owners
|
🤖 Created branch: z_pr2770/sridhargaddam/podcidr-discovery |
sridhargaddam
force-pushed
the
podcidr-discovery
branch
from
dfa8e79 to
2130ada
Compare
skitt
approved these changes
Sep 1, 2023
|
This fix is not only for generic clusters but also for calico clusters. |
In K8s, each node is typically assigned a unique PodCIDR range for the pods that run on that node. Each node's PodCIDR is used to allocate IP addresses to the pods scheduled on that node. Only if the cluster is a single node deployment, we should rely on the node.Spec.PodCIDR as podCIDR of the cluster. Related to: submariner-io/submariner#2128 Signed-off-by: Sridhar Gaddam <[email protected]>
sridhargaddam
force-pushed
the
podcidr-discovery
branch
from
2130ada to
c1e6fab
Compare
sridhargaddam
changed the title
yboaron
approved these changes
Sep 5, 2023
|
🤖 Closed branches: [z_pr2770/sridhargaddam/podcidr-discovery] |
|
@sridhargaddam Do you think this should be backported? |
dfarrell07
added
the
backport
Yes @dfarrell07, this will be useful for environments like K3s. I'll handle the backports. |
dfarrell07
added
the
release-note-needed
sridhargaddam
added a commit
to sridhargaddam/submariner-website
that referenced
this pull request
Sep 26, 2023
This PR includes release notes for submariner-io/submariner-operator#2770 Signed-off-by: Sridhar Gaddam <[email protected]>
|
Release note PR: submariner-io/submariner-website#1037 |
sridhargaddam
added a commit
to sridhargaddam/submariner-website
that referenced
this pull request
Sep 26, 2023
This PR includes release notes for submariner-io/submariner-operator#2770 Signed-off-by: Sridhar Gaddam <[email protected]>
sridhargaddam
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Sep 26, 2023
This PR includes release notes for submariner-io/submariner-operator#2770 Signed-off-by: Sridhar Gaddam <[email protected]>
sridhargaddam
added a commit
to sridhargaddam/submariner-website
that referenced
this pull request
Sep 26, 2023
This PR includes release notes for submariner-io/submariner-operator#2770 Signed-off-by: Sridhar Gaddam <[email protected]>
tpantelis
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Sep 27, 2023
This PR includes release notes for submariner-io/submariner-operator#2770 Signed-off-by: Sridhar Gaddam <[email protected]>
dfarrell07
pushed a commit
to dfarrell07/submariner-website
that referenced
this pull request
Oct 18, 2023
This PR includes release notes for submariner-io/submariner-operator#2770 Signed-off-by: Sridhar Gaddam <[email protected]>
dfarrell07
pushed a commit
to dfarrell07/submariner-website
that referenced
this pull request
Oct 18, 2023
This PR includes release notes for submariner-io/submariner-operator#2770 Signed-off-by: Sridhar Gaddam <[email protected]>
dfarrell07
pushed a commit
to dfarrell07/submariner-website
that referenced
this pull request
Oct 19, 2023
This PR includes release notes for submariner-io/submariner-operator#2770 Signed-off-by: Sridhar Gaddam <[email protected]>
tpantelis
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Oct 22, 2023
This PR includes release notes for submariner-io/submariner-operator#2770 Signed-off-by: Sridhar Gaddam <[email protected]>
tpantelis
pushed a commit
to tpantelis/submariner-website
that referenced
this pull request
Nov 3, 2023
This PR includes release notes for submariner-io/submariner-operator#2770 Signed-off-by: Sridhar Gaddam <[email protected]>
tpantelis
pushed a commit
to tpantelis/submariner-website
that referenced
this pull request
Nov 6, 2023
This PR includes release notes for submariner-io/submariner-operator#2770 Signed-off-by: Sridhar Gaddam <[email protected]>
tpantelis
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Nov 6, 2023
This PR includes release notes for submariner-io/submariner-operator#2770 Signed-off-by: Sridhar Gaddam <[email protected]>
tpantelis
pushed a commit
to tpantelis/submariner-website
that referenced
this pull request
Nov 7, 2023
This PR includes release notes for submariner-io/submariner-operator#2770 Signed-off-by: Sridhar Gaddam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In K8s, each node is typically assigned a unique PodCIDR range for the pods that run on that node. Each node's PodCIDR is used to allocate IP addresses to the pods scheduled on that node. Only if the cluster is a single node deployment, we should rely on the node.Spec.PodCIDR as podCIDR of the cluster.
Related to: submariner-io/submariner#2128
Related to: submariner-io/submariner#2489
Signed-off-by: Sridhar Gaddam [email protected]