Use -n option for in-cluster rest config #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
Jaanki,
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr1254/tpantelis/in-cluster-ns |
tpantelis
force-pushed
the
in-cluster-ns
branch
from
d19d113 to
ebb8ef2
Compare
skitt
reviewed
Nov 6, 2024
internal/restconfig/producer_test.go
Outdated
|
|
||
| It("should return false", func() { | ||
| wasRun, err := t.producer.RunOnSelectedPrefixedContext(prefix, func(_ *cluster.Info, _ string, _ reporter.Interface) error { | ||
| return nil |
There was a problem hiding this comment.
Suggested change
| return nil | |
| t.actualProcessed++ | |
| return nil |
There was a problem hiding this comment.
I assume you mean skipped wrt using noopPerContext - no I missed thus one.
|
For some bizarre reason GitHub won’t let me request changes, just submit review comments. |
Signed-off-by: Tom Pantelis <[email protected]>
...to provide a hook for unit tests. Signed-off-by: Tom Pantelis <[email protected]>
...so the prefixed "namespace" flag is added. Signed-off-by: Tom Pantelis <[email protected]>
...that creates fake client sets for unit tests. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
in-cluster-ns
branch
from
ebb8ef2 to
8233d98
Compare
Also refactored the production code a little to increase branch coverage. Signed-off-by: Tom Pantelis <[email protected]>
Fixes submariner-io#324 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
in-cluster-ns
branch
from
8233d98 to
f3806ae
Compare
skitt
approved these changes
Nov 12, 2024
dfarrell07
approved these changes
Nov 12, 2024
|
🤖 Closed branches: [z_pr1254/tpantelis/in-cluster-ns] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR first adds unit tests for the
restconfigmodule along with some minor supporting changes to the production code.Fixes #324