Check route agent connections in subctl diagnose #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
Jaanki,
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr1228/tpantelis/route_agent_diag |
tpantelis
force-pushed
the
route_agent_diag
branch
from
28b6649 to
d9dc74c
Compare
|
This PR/issue depends on:
|
tpantelis
force-pushed
the
route_agent_diag
branch
3 times, most recently
from
7f2a515 to
341e1ee
Compare
Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
route_agent_diag
branch
from
341e1ee to
3a8d115
Compare
tpantelis
requested review from
aswinsuryan,
dfarrell07 and
maayanf24
as code owners
5 tasks
dfarrell07
approved these changes
Sep 23, 2024
yboaron
reviewed
Sep 24, 2024
| return status.Error(err, "Error retrieving route agents") | ||
| } | ||
|
|
||
| if len(routeAgents) == 0 { |
There was a problem hiding this comment.
Do we need to consider if submariner.healthcheck != enabled ?
There was a problem hiding this comment.
We create a RouteAgent resource regardless (same with Gateways).
yboaron
approved these changes
Sep 24, 2024
aswinsuryan
approved these changes
Sep 24, 2024
|
🤖 Closed branches: [z_pr1228/tpantelis/route_agent_diag] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on submariner-io/submariner#3166