Switch to Fedora for nettest and use packaged netperf #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skitt
requested review from
mkolesnik,
Oats87,
sridhargaddam,
tpantelis and
vthapar
as code owners
|
🤖 Created branch: z_pr1766/skitt/fedora-nettest |
skitt
force-pushed
the
fedora-nettest
branch
2 times, most recently
from
ce3b336 to
a574f74
Compare
netperf currently fails to build with the latest Alpine images, even with _GNU_SOURCE fixes. To allow building the nettest image again, this switches to Fedora, where netperf is available as a package (so we don't need to deal with building it). The image size is more than doubled, from 24.2MiB with Alpine to 59.8MiB with Fedora. This ends up with nmap ncat rather than busybox ncat, so the nettest scripts are adjusted to suit, and a busybox nc emulation script is included for other users of nc. Signed-off-by: Stephen Kitt <[email protected]>
skitt
force-pushed
the
fedora-nettest
branch
from
a574f74 to
f058280
Compare
tpantelis
approved these changes
Dec 12, 2024
vthapar
approved these changes
Dec 16, 2024
|
🤖 Closed branches: [z_pr1766/skitt/fedora-nettest] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
netperf currently fails to build with the latest Alpine images, even with _GNU_SOURCE fixes.
To allow building the nettest image again, this switches to Fedora, where netperf is available as a package (so we don't need to deal with building it). The image size is more than doubled, from 24.2MiB with Alpine to 59.8MiB with Fedora.
This ends up with nmap ncat rather than busybox ncat, so the nettest scripts are adjusted to suit, and a busybox nc emulation script is included for other users of nc.