Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP-* versions should be based on the min/max version of LSP #97

Closed
wants to merge 5 commits into from
Closed

LSP-* versions should be based on the min/max version of LSP #97

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c94763a
fix: LSP-* versions should be based on the min/max version of LSP
predragnikolic Feb 3, 2024
f6f7596
fix the rest of the versions
predragnikolic Feb 3, 2024
074d364
revert Julia because it uses sublime_plugin.ListInputHandler, and Cop…
predragnikolic Feb 4, 2024
9560c10
revert volar because it uses CLEAR_TO_RIGHT(4100) and command_url(4075)
predragnikolic Feb 4, 2024
9c26ac7
revert lsp-yaml because it uses find_syntax_for_file(4081)
predragnikolic Feb 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 25 additions & 25 deletions repository.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"releases": [
{
"base": "https://github.com/sublimelsp/lsp_utils",
"sublime_text": "3000 - 4069",
"sublime_text": "3154 - 4069",
"tags": "st3-v"
},
{
Expand All @@ -33,7 +33,7 @@
],
"releases": [
{
"sublime_text": ">=4000",
"sublime_text": ">=4070",
"tags": true
}
]
Expand Down Expand Up @@ -197,7 +197,7 @@
],
"releases": [
{
"sublime_text": ">=4126",
"sublime_text": ">=4070",
"tags": true
}
]
Expand All @@ -212,7 +212,7 @@
],
"releases": [
{
"sublime_text": ">=4126",
"sublime_text": ">=4070",
"tags": true
}
]
Expand All @@ -229,11 +229,11 @@
],
"releases": [
{
"sublime_text": "3154 - 4147",
"sublime_text": "3154 - 4069",
"tags": "st3-"
},
{
"sublime_text": ">=4148",
"sublime_text": ">=4070",
"tags": true
}
]
Expand Down Expand Up @@ -331,11 +331,11 @@
],
"releases": [
{
"sublime_text": "3154 - 3999",
"sublime_text": "3154 - 4069",
"tags": "st3-"
},
{
"sublime_text": ">=4000",
"sublime_text": ">=4070",
"tags": true
}
]
Expand Down Expand Up @@ -435,11 +435,11 @@
],
"releases": [
{
"sublime_text": "3154 - 4147",
"sublime_text": "3154 - 4069",
"tags": "st3-"
},
{
"sublime_text": ">=4148",
"sublime_text": ">=4070",
"tags": true
}
]
Expand Down Expand Up @@ -490,11 +490,11 @@
],
"releases": [
{
"sublime_text": "3154 - 4147",
"sublime_text": "3154 - 4069",
"tags": "st3-"
},
{
"sublime_text": ">=4148",
"sublime_text": ">=4070",
"tags": true
}
]
Expand All @@ -512,7 +512,7 @@
],
"releases": [
{
"sublime_text": ">=4095",
"sublime_text": ">=4070",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not possible to change to 4070. I put this on purpose to 4095 because LSP-julia uses sublime.ListInputItem which was introduced with ST 4095.

The 4070 restriction for the main LSP package is mostly meaningless anyway, because I'm almost sure it uses various things from the ST API that were introduced after build 4070. Personally I also don't like the 4070- prefix for the version tags (purely for aesthetic reasons). iirc it was introduced to make it possible to add new release prefixes with increased build numbers whenever new functionality from the ST API gets used in LSP. But apparently this didn't happen in the past and also nobody really cares about it, so I guess it can just stay like this (4070) forever and in the case of any issue reports get filed in the future for the use of API incompatible with older ST builds, we could just fix those gradually with if ST_VERSION > XXXX checks in the code, if possible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out.

I went through the LSP-* packages again
and checked if other packages use sublime.* apis introduced in later versions of ST and reverted the versions.

"tags": true
}
]
Expand Down Expand Up @@ -626,11 +626,11 @@
],
"releases": [
{
"sublime_text": "3154 - 3999",
"sublime_text": "3154 - 4069",
"tags": "st3-"
},
{
"sublime_text": ">=4000",
"sublime_text": ">=4070",
"tags": true
}
]
Expand Down Expand Up @@ -674,7 +674,7 @@
],
"releases": [
{
"sublime_text": ">=4126",
"sublime_text": ">=4070",
"tags": true
}
]
Expand Down Expand Up @@ -718,11 +718,11 @@
],
"releases": [
{
"sublime_text": "3154 - 4147",
"sublime_text": "3154 - 4069",
"tags": "st3-"
},
{
"sublime_text": ">=4148",
"sublime_text": ">=4070",
"tags": true
}
]
Expand Down Expand Up @@ -787,7 +787,7 @@
],
"releases": [
{
"sublime_text": "3154 - 3999",
"sublime_text": "3154 - 4069",
"tags": true
}
]
Expand Down Expand Up @@ -916,11 +916,11 @@
],
"releases": [
{
"sublime_text": "3154 - 3999",
"sublime_text": "3154 - 4069",
"tags": "st3-"
},
{
"sublime_text": ">=4000",
"sublime_text": ">=4070",
"tags": true
}
]
Expand Down Expand Up @@ -968,11 +968,11 @@
],
"releases": [
{
"sublime_text": "3154 - 4147",
"sublime_text": "3154 - 4069",
"tags": "st3-"
},
{
"sublime_text": ">=4148",
"sublime_text": ">=4070",
"tags": true
}
]
Expand Down Expand Up @@ -1006,11 +1006,11 @@
],
"releases": [
{
"sublime_text": "3154 - 4147",
"sublime_text": "3154 - 4069",
"tags": "st3-"
},
{
"sublime_text": ">=4148",
"sublime_text": ">=4070",
"tags": true
}
]
Expand Down