Add LSP-basedpyright #113
Merged
Add LSP-basedpyright #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
STReviewBot
suggested changes
Mar 29, 2024
There was a problem hiding this comment.
Automated testing result: ERROR
Repo link: LSP-basedpyright
Results help
Packages added:
- LSP-basedpyright
Processing package "LSP-basedpyright"
- ERROR: No valid semver tags found at https://github.com/sublimelsp/LSP-basedpyright/tags for the package "LSP-basedpyright".
jfcherng
force-pushed
the
feat/lsp-basedpyright
branch
from
2a4c9b2 to
4f39f20
Compare
STReviewBot
suggested changes
Mar 29, 2024
There was a problem hiding this comment.
Automated testing result: ERROR
Repo link: LSP-basedpyright
Results help
Packages added:
- LSP-basedpyright
Processing package "LSP-basedpyright"
- ERROR: Calling unsafe method 'packages_path' of sublime module when API may not have been initialized
- File: plugin.py
- Line: 17, Column: 20
- ERROR: File 'messages/1.1.68.md', as specified by key '1.1.68', does not exist
- File: messages.json
- WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
- File: plugin.py
- Line: 32, Column: 8
- WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
- File: plugin.py
- Line: 222, Column: 16
- WARNING: Command class 'LspBasedpyrightCreateConfiguration' does not end with 'Command'
- File: commands.py
- Line: 16, Column: 1
4f39f20 to
4d29544
Compare
Signed-off-by: Jack Cherng <[email protected]>
STReviewBot
suggested changes
Mar 29, 2024
There was a problem hiding this comment.
Automated testing result: ERROR
Repo link: LSP-basedpyright
Results help
Packages added:
- LSP-basedpyright
Processing package "LSP-basedpyright"
- ERROR: Calling unsafe method 'packages_path' of sublime module when API may not have been initialized
- File: plugin.py
- Line: 16, Column: 20
- WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
- File: plugin.py
- Line: 28, Column: 8
- WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
- File: plugin.py
- Line: 218, Column: 16
|
As per ST API docs, |
predragnikolic
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/sublimelsp/LSP-basedpyright