Skip to content

Releases: subhojit777/views_base_url

Bug fixes, code improvements and new tests added

21 Sep 06:38
@subhojit777 subhojit777
8.x-1.0
e178e9d
Compare
Choose a tag to compare
Bug fixes, code improvements and new tests added Latest
Latest

Bug fixes

  • No replacement patterns available.
  • Image as link not working.

New tests added

  • Views base url no link test.
  • Views base url with no link query test.
  • Views base url with link query test.
  • Views base url with no link text test.
  • Views base url with link text set test.
  • Views base url link path not set test.
  • Views base url as link with link_path set test.
  • Render as link with all settings test.

Issue [#2909157] by subhojit777: Code improvements

  • Module file was empty, and hence removed.
  • The module will now rely on release updates, and Git commits rather than maintaining a CHANGELOG. CHANGELOG removed.
  • Tokens are only fetched if show_link is enabled. Earlier it was fetched nevertheless.
  • Link text is now generated directly from link path. Earlier it was checking whether the path is aliased or not, and then it was generating the link text. The check is now removed.
  • Link class is now generated directly. Earlier there was an if condition that checked whether it is set or not. The condition is now removed.
  • render() now returns renderable array. Earlier it was returning a string. This is changed as per the new Drupal core.
  • Removed deprecated methods from views field plugin.
  • Token replacement moved to separate method.
  • Drupal code standard fixes in the views field plugin.

Issue [#2413525] by subhojit777: Test improvements

  • Single assert function for testing multiple cases when no link settings are set.
  • Number of node generated during test is reduced.
  • Data type mentioned properties.
  • Instead of hard coding node count, it is now declared as a test-wide property.
  • Nodes are now created in setUp() rather than inside a test.
  • Instead of asserting whether the HTML of link image is present on the page, we are now using xpath. This new method if testing will make sure that the stable release of this module will not be blocked by [#2544110].
  • TravisCI integration.
  • Drupal code standard fixes.
  • Replaced deprecated method.
  • Note that we have to use WebTestBase because the test is dependent on drupalGetTestFiles().
Assets 2
Loading