Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hover effect on the navbar which is visually unappealing and incomplete background on hover #280 #282

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amanreddy77
Copy link

Fix hover effect on the navbar which is visually unappealing and incomplete background on hover #280

Description

The "Home" link on the navigation bar was not applying the intended transition and hover effects when the current route was /. The transition-related classes were missing when the route matched '/', causing the hover and animation effects to be inactive.

  • Updated the conditional classes in the Home link to ensure that transition and hover-related classes (transition-all, transform, hover:scale-105, etc.) are applied regardless of the current route.
  • Now, even when currentRoute === '/', the hover and transition effects are applied correctly along with the red text color.

Fixes #280

Related Issue

None

Screenshot

Screen.Recording.2024-10-20.at.16.33.08.mov

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Oct 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bio-branch-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2024 11:04am

@amanreddy77
Copy link
Author

hey @subhadipbhowmik please merge my PR i solves the mentioned issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix hover effect on the navbar which is visually unappealing and incomplete background on hover
1 participant