Skip to content
This repository has been archived by the owner on Sep 21, 2024. It is now read-only.

chore: Upgrade reqwest to 0.12, without macos-system-configuration. Fixes #686 #866

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

jsantell
Copy link
Contributor

@jsantell jsantell commented Mar 25, 2024

Cleans up a handful of duplicated transitive http dependencies and issues with using an "old" reqwest with newer axum and related http utils. Fixes #686

@jsantell jsantell force-pushed the reqwest-0.12 branch 2 times, most recently from d273477 to eba6268 Compare March 25, 2024 18:15
Copy link
Contributor

github-actions bot commented Mar 25, 2024

Test flake analysis

status platform features toolchain
🟡 ubuntu-latest test-kubo,headers nightly
🟢 macos-13 test-kubo,headers,rocksdb stable
🟢 windows-latest test-kubo,headers stable
🟡 macos-13 test-kubo,headers stable
🟢 ubuntu-latest test-kubo,headers,rocksdb stable
🟢 ubuntu-latest test-kubo,headers stable

Flake summary for ubuntu-latest, test-kubo,headers, nightly

     Summary [  54.185s] 210 tests run: 210 passed (1 flaky), 2 skipped
   FLAKY 2/5 [   4.521s] noosphere::distributed_basic gateway_publishes_and_resolves_petnames_configured_by_the_client

Flake summary for macos-13, test-kubo,headers, stable

     Summary [ 101.385s] 210 tests run: 210 passed (1 slow, 1 flaky), 2 skipped
   FLAKY 2/5 [   1.669s] noosphere::client_to_gateway gateway_updates_an_existing_sphere_with_changes_from_the_client

Copy link
Contributor

@gordonbrander gordonbrander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QQ: Do we know what's up with the test flake? Is this a regression or expected?

Otherwise LGTM.

@jsantell
Copy link
Contributor Author

QQ: Do we know what's up with the test flake? Is this a regression or expected?

Otherwise LGTM.

No regressions, some flakes on integration tests on some known issues: #579

@jsantell jsantell merged commit f0f116c into main Mar 28, 2024
23 checks passed
@jsantell jsantell deleted the reqwest-0.12 branch March 28, 2024 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating reqwest to 0.11.22 causes macos build failure, requires SystemConfiguration
2 participants