This repository has been archived by the owner on Sep 21, 2024. It is now read-only.
fix: some fixes for downstream cloud hosting work #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test flake analysis
Flake summary for
|
jsantell
force-pushed
the
downstream-fixes
branch
5 times, most recently
from
50255bc
to
4f4ea6d
Compare
jsantell
force-pushed
the
downstream-fixes
branch
2 times, most recently
from
df5069e
to
098bc6d
Compare
This was referenced Mar 26, 2024
* Cyclic dependency issues downstream: * Remove vestigial getrandom dep from noosphere-core (add notes to the usage in noosphere-core after further investigation) * Remove deprecated (due to cyclic dep issues) `serde-serialize` feature from wasm-bindgen * Make gateway routing traits public * Provide blanket implementations of `JobClient` for `Arc<JobClient>` * Scope `GatewayManager::ucan_store()` by gateway sphere identity, as well as other GatewayManager methods (in lieu of counterpart)
jsantell
force-pushed
the
downstream-fixes
branch
from
098bc6d
to
19eaba2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes to support extending noosphere downstream:
serde-serializefeature from wasm-bindgenJobClientforArc<JobClient>GatewayManager::ucan_store()by gateway sphere identity, as well as other GatewayManager methods (in lieu of counterpart)