This repository has been archived by the owner on Sep 21, 2024. It is now read-only.
chore: Remove ineffective Sentry initialization #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rolls back part of #437 . The result of Sentry initialization has to outlive the inner lifetime of whatever process it's observing, so it's better to conceptualize it as initialized outside of the
initialize_tracinghelper. Meanwhile,sentry_tracing::layer()can just exist as part of the subscriber with or without an initialized Sentry.Also, uplifted the
sentry-tracingdep to the workspace level.