chore: Fix potentially cyclic dependencies downstream:

* Remove vestigial "getrandom" dependency * Remove "serde-deserialize" feature in "wasm-bindgen" * Make `noosphere_core::api::route` public
subconsciousnetwork · Mar 25, 2024 · 62050ce · 62050ce
1 parent 116c071
commit 62050ce
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 12 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -47,7 +47,6 @@ ed25519-dalek = { version = "2" }
 fastcdc = { version = "3.1" }
 futures = { version = "^0.3.30" }
 futures-util = { version = "0.3" }
-getrandom = { version = "~0.2", features = ["js"]}
 gloo-net = { version = "0.4" }
 gloo-timers = { version = "0.3", features = ["futures"] }
 ignore = { version = "0.4.20" }

diff --git a/rust/noosphere-core/Cargo.toml b/rust/noosphere-core/Cargo.toml
@@ -73,8 +73,6 @@ tokio = { workspace = true, features = ["full"] }
 tracing-subscriber = { workspace = true }
 
 [target.'cfg(target_arch = "wasm32")'.dependencies]
-# NOTE: This is needed so that rand can be included in WASM builds
-getrandom = { workspace = true, features = ["js"] }
 gloo-net = { workspace = true }
 wasm-streams = { workspace = true }
 wasm-bindgen = { workspace = true }

diff --git a/rust/noosphere-core/src/api/mod.rs b/rust/noosphere-core/src/api/mod.rs
@@ -11,6 +11,7 @@ pub mod v0alpha2;
 
 pub use client::*;
 pub use data::*;
+pub use route::*;
 
 // Re-export `http::StatusCode` here as our preferred `StatusCode` instance,
 // disambiguating from other crate's implementations.

diff --git a/rust/noosphere-storage/Cargo.toml b/rust/noosphere-storage/Cargo.toml
@@ -50,7 +50,7 @@ rocksdb = { version = "0.22.0", optional = true }
 
 [target.'cfg(target_arch = "wasm32")'.dependencies]
 tokio = { workspace = true, features = ["sync", "macros"] }
-wasm-bindgen = { workspace = true, features = ["serde-serialize"] }
+wasm-bindgen = { workspace = true }
 wasm-bindgen-futures = { workspace = true }
 serde-wasm-bindgen = { workspace = true }
 js-sys = { workspace = true }

diff --git a/rust/noosphere-ucan/Cargo.toml b/rust/noosphere-ucan/Cargo.toml
@@ -53,10 +53,6 @@ wasm-bindgen = { workspace = true, optional = true }
 wasm-bindgen-futures = { workspace = true, optional = true }
 js-sys = { workspace = true, optional = true }
 
-[target.'cfg(target_arch = "wasm32")'.dependencies]
-# NOTE: This is needed so that rand can be included in WASM builds
-getrandom = { workspace = true, features = ["js"] }
-
 [dev-dependencies]
 serde_ipld_dagcbor = { workspace = true }
 wasm-bindgen-test = { workspace = true }