Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polished as peer dependency #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

polished as peer dependency #8

wants to merge 1 commit into from

Conversation

wangzuo
Copy link

@wangzuo wangzuo commented Dec 2, 2018

This pr also fixes test script

@andrejpavlovic andrejpavlovic mentioned this pull request Aug 23, 2019
Open
@andrejpavlovic
Copy link

The peer dependency could be bumped to version 3 of polished - seems to work fine

@crutchcorn
Copy link

I'm wondering if we're able to get this merged in by any chance. While resolutions in yarn works, it has concerns regarding maintainability

@asherccohen
Copy link

Same here, when can we expect the fix to be merged?
#9 (comment)

@michaelmccord
Copy link

Is there any chance we could get a merge on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wangzuo @andrejpavlovic @crutchcorn @asherccohen @michaelmccord