Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node versions for github workflows #236

Merged
merged 8 commits into from
Mar 25, 2024
Merged

Update node versions for github workflows #236

merged 8 commits into from
Mar 25, 2024

Conversation

gulcinuras
Copy link
Contributor

@gulcinuras gulcinuras commented Jan 17, 2024 •
edited
Loading

As discussed with @jamcry, we decided to update the gh-workflows as well

  • Updated the babel-loader to the latest, since it was giving a CI/CD error on storybook configurations.

@gulcinuras gulcinuras self-assigned this Jan 17, 2024
@gulcinuras gulcinuras added W.I.P Work in progress and removed ready for review labels Jan 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-03-25 15:29 UTC

@gulcinuras gulcinuras added ready for review and removed W.I.P Work in progress labels Mar 11, 2024
@jamcry
Copy link
Collaborator

jamcry commented Mar 25, 2024

thanks @gulcinuras , I think we will need to update pr preview workflow as well,
I realized it uses node 14, which might cause a problem
https://github.com/Hipo/react-ui-toolkit/blob/next-release/.github/workflows/pr-preview.yml

@gulcinuras
Copy link
Contributor Author

thanks @gulcinuras , I think we will need to update pr preview workflow as well, I realized it uses node 14, which might cause a problem https://github.com/Hipo/react-ui-toolkit/blob/next-release/.github/workflows/pr-preview.yml

Hi @jamcry, yes this pr includes pr preview workflow updates as well 👍🏾

@jamcry
Copy link
Collaborator

jamcry commented Mar 25, 2024

thanks @gulcinuras , I think we will need to update pr preview workflow as well, I realized it uses node 14, which might cause a problem https://github.com/Hipo/react-ui-toolkit/blob/next-release/.github/workflows/pr-preview.yml

Hi @jamcry, yes this pr includes pr preview workflow updates as well 👍🏾

ah sorry I was checking the commit not the pr I guess 👍

yasincaliskan
yasincaliskan approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@yasincaliskan yasincaliskan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉

@jamcry jamcry merged commit 3637c38 into next-release Mar 25, 2024
1 check passed
@jamcry jamcry deleted the fix/update-workflow-node-version branch March 25, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamcry jamcry jamcry approved these changes

@yasincaliskan yasincaliskan yasincaliskan approved these changes

@Anlerkan Anlerkan Awaiting requested review from Anlerkan

@tatata96 tatata96 Awaiting requested review from tatata96

Assignees

@gulcinuras gulcinuras

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gulcinuras @jamcry @yasincaliskan