Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 adding schema for individual components #25

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

SmithRWORNL
Copy link
Collaborator

No description provided.

Added schemas for each section, as well as Github actions to run them.

Also fixed some invalid JSON in the .jsonld sections.

Addresses #5
Number under parameter should be a string, not a number.
Number can be either a number or a string.
There is no scidata example to validate.
@SmithRWORNL SmithRWORNL requested a review from stuchalk February 15, 2024 16:45
@SmithRWORNL SmithRWORNL self-assigned this Feb 15, 2024
Copy link
Owner

@stuchalk stuchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good. Thanks for the updates/additions.

@stuchalk stuchalk merged commit ba00253 into main Feb 15, 2024
2 checks passed
@marshallmcdonnell
Copy link
Contributor

Wow, @SmithRWORNL, you got basically all the schema 🤯 🎉

Thanks so much!
Great work! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants