Sorted url query parameters for better caching support #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gajddo00
requested review from
a team and
matejmolnar
and removed request for
a team
matejmolnar
approved these changes
May 8, 2024
There was a problem hiding this comment.
⚽
I would just add that this change is necessary due to how CDNs work. Usually they determine whether to return a cached response for a request simply based on the url string comparison, which means that if you happen to switch the order of url parameters between requests it doesn't return the cached response.
arkhigleb
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances the possibility for URL addresses to be cacheable.