#90 - added tests for the sj:a and the sj:div tag #93
Conversation
sdutry
changed the title
| language: java | ||
| jdk: | ||
| - oraclejdk8 | ||
| script: "mvn verify" |
There was a problem hiding this comment.
Why did you use verify? Because of maven-failsafe-plugin?
There was a problem hiding this comment.
It's because of the maven-failsafe-plugin indeed.
The plugin is bound to the goals integration-test and verify
The required jetty-server for these tests:
- starts during
pre-integration-test - stops during
post-integration-test
If you have a better solution or preferred alternative, please let me know so i can adjust accordingly.
There was a problem hiding this comment.
Nope, I just wanted be sure that I understand. This is cool 👍
| @@ -92,6 +92,7 @@ | |||
| <module>struts2-jquery-grid-showcase</module> | |||
| <module>struts2-jquery-mobile-showcase</module> | |||
| <module>struts2-jquery-archetypes</module> | |||
| <module>struts2-jquery-plugin-tests</module> | |||
There was a problem hiding this comment.
What do you think about naming this module struts2-jquery-integration-tests or something like that?
There was a problem hiding this comment.
I will rename this as per your suggestion to struts2-jquery-integration-tests
What would you suggest about future tests concerning different modules (eg: struts2-jquery-tree-plugin) ?
Which would you prefer:
- add those tests to the
struts2-jquery-integration-testsmodule - seperate module named according to the tested module (eg:
struts2-jquery-tree-integration-tests)
There was a problem hiding this comment.
Thanks :)
Regarding additional tests & modules, I think for now it's ok to put them in struts2-jquery-integration-tests - it will simplify configuration & maintenance burden :)
|
@jogep I also updated the versions of the project and modules to please confirm again that this pull request may be merged, or feel free to merge it yourself. If you still see problems with it, please let me know and i'll try to fix them asap |
|
@sdutry I merged it to the 4.0.3 branch. Thank you for this contribution! |
#90
This is a first step towards adding tests for all the struts2-jquery-plugin tags.
It would be nice if we had the
Travic-CIintegration set-up. (as suggested by @lukaszlenart )The only person who can activate this would be the project owner.
With
Travic-CIset-up there would be a build automaticaly started whenever a commit or pull-request is done, running the tests and showing when it would break something (that's currently being tested for).