Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

fixes #1 Not converting #2

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

fixes #1 Not converting #2

wants to merge 22 commits into from

Conversation

quif
Copy link

@quif quif commented Feb 25, 2023

Fixes

Fixed every conversion bug I came across, including:

  • addon gets stuck on converting because the the folder structure of some eBook pages is different.
  • when the addon can't convert a pdf page in one format, it renders the page in the other format.
  • missing pictures

Additions

  • Added an optional safe mode. In some cases the pdf breaks when a page fails to convert. Because this fix is quite slow it is optional.

I did not fix the problem hellooas is having where it looks like the addon is not detecting the eBook.

quif and others added 22 commits August 25, 2022 20:56
@quif
Changed name for better destinction between original Add-On.
5d90835 
Tried to implement fix for downloading books with different url. (half working)
@quif
Fixed image loading
4ee8e6b 
(every book can be downloaded correctly)
@quif
Cleanup and renaming base_url => bookURL
c24ec2e
@quif
Pages that can't be converted in SVG are rendered in PNG
75690d1 
and vice versa.
(doesn't delete svg in page (bad))
@quif
Merge branch 'strukteon:master' into master
23ec6a8
@quif
prepare for pull request
05f0d07
@quif
changes Readme
0a03a89
@quif
changed console.log("start page") to print the corret page
e733262
@quif
Deleted duplicate file
d94f73b
@quif
fixed bug where pdf could break when add_as_vector failed
1039196
@quif
formatted code and set indent to 2
6bdbefe
@quif
set deph of recursiveAllChildImagesToURI to 4
a3760a3
@quif
backend implementation for safe mode
b1a8b6d
@quif
added name in popup.html
dea77b6
@quif
forgot link
8cf41f1
@quif
frontend implementation for safe mode
43e2072
@quif
added debugLog funcion
7f58b1f
@quif
put converting into functions
bb6e5ec
@quif
forgot staging
bee6f69
@quif
fixed bug in debugLog
0b3d7e9
@FlorianSchwarzl
Update README.md
b08506c
@quif
Merge pull request #1 from plastik-flasche/master
90a3976 
Update README.md
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

strukteon
strukteon approved these changes Mar 19, 2023
View reviewed changes
Copy link
Owner

@strukteon strukteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

@strukteon
Copy link
Owner

will merge and update the chrome/firefox pages when i find the time

@dhaydl
Copy link

dhaydl commented Oct 10, 2023

Hi,

any chances that the fixes will be merged and published to chrome web store soon?

I would really urgently need this extension. Guides to run the extension locally on my end with the fixes are also appreciated.

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@strukteon strukteon strukteon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quif @strukteon @dhaydl @FlorianSchwarzl