Skip to content

Commit

Permalink
Remove moodle.* sniffs from moodle ruleset
Browse files Browse the repository at this point in the history
Unless needed to be configured (severity, config option..) own
moodle.* sniffs don't have to be added to the standard ruleset.

Fixes moodlehq#75
  • Loading branch information
stronk7 committed Dec 3, 2023
1 parent a415a54 commit ce08ab2
Showing 1 changed file with 0 additions and 16 deletions.
16 changes: 0 additions & 16 deletions moodle/ruleset.xml
Original file line number Diff line number Diff line change
Expand Up @@ -107,21 +107,6 @@

<rule ref="Zend.Files.ClosingTag"/>

<!--
Detect issues with Unit Test dataProviders:
- private providers
- providers which do not exist
- providers whose name is prefixed with _test
- incorrect casing of dataProvider
- dataProviders which do not return an array or Iterable
-->
<rule ref="moodle.PHPUnit.TestCaseProvider"/>

<!--
Tests should have a return type. The default return type should be void.
-->
<rule ref="moodle.PHPUnit.TestReturnType"/>

<!-- Disable this exact error unless it's approved -->
<rule ref="moodle.Commenting.InlineComment.SpacingAfter">
<severity>0</severity>
Expand All @@ -131,7 +116,6 @@
Namespace statements, and class imports (use statements) should not use a leading backslash.
-->
<rule ref="PSR12.Files.ImportStatement.LeadingSlash"/>
<rule ref="moodle.Namespaces.NamespaceStatement"/>

<!-- Let's add the complete PHPCompatibility standard -->
<rule ref="PHPCompatibility" />
Expand Down

0 comments on commit ce08ab2

Please sign in to comment.