Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support moto parameter #872

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] Support moto parameter #872

wants to merge 1 commit into from

Conversation

tim-lin-bbpos
Copy link
Collaborator

Summary

Support moto parameter

Motivation

https://jira.corp.stripe.com/browse/TERMINAL-41667

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • Require doc changes
  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@tim-lin-bbpos
Copy link
Collaborator Author

Hi @mindy-stripe, I was working on moto changes and I follow the test guide but for collectSetupIntentPaymentMethod usecase still fail, is there anything I'm missing?
Screenshot_20250106_163320

@mindy-stripe
Copy link
Collaborator

Hi @mindy-stripe, I was working on moto changes and I follow the test guide but for collectSetupIntentPaymentMethod usecase still fail, is there anything I'm missing?

hi @tim-lin-bbpos when you create the SetupIntent the payment method type should include card and not just card_present, you need to make a test app change to add that payment method type

@tim-lin-bbpos
Copy link
Collaborator Author

@mindy-stripe
The setupIntent is created by createSetupIntent function in RN, but even I add card I still got the same result.

      const response = await createSetupIntent({
        customer: resp.id,
      });
      setupIntent = response.setupIntent;
      setupIntent?.paymentMethodTypes?.push('card'); // new added
      console.log('setupIntent', setupIntent); // new added
      setupIntentError = response.error;

The log of setupIntent object:

setupIntent {"applicationId": null, "clientSecret": "xxxxx", "created": "1736393748000", "customer": "cus_RXGAy2ZzGdgye9", "description": null, "id": "xxxx", "latestAttempt": null, "mandateId": null, "metadata": {}, "onBehalfOfId": null, "paymentMethodId": null, "paymentMethodTypes": ["card_present", "card"], "sdkUuid": "e87ad355-a9c3-4b47-a836-xxxxxx", "singleUseMandateId": null, "status": "requiresPaymentMethod", "usage": "offSession"}

@nazli-stripe
Copy link
Collaborator

@tim-lin-bbpos can you share the ID's of the setupIntent too, so we can take a look

Base automatically changed from bbpos/version4.1 to main January 13, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants