Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipe rubocop output to devnull #1521

Merged
merged 1 commit into from
Jan 17, 2025
Merged

pipe rubocop output to devnull #1521

merged 1 commit into from
Jan 17, 2025

Conversation

xavdid-stripe
Copy link
Member

Why?

Codegen for ruby was failing because just format for ruby was creating too much output. It turns out that even during "quiet" mode, rubocop prints outs the things it corrects (which there are a ton of during generation).

So we need to pipe everything to /dev/null so there's no printing at all. I've confirmed this all works locally!

What?

  • pipe formatting output to /dev/null

See Also

justfile Show resolved Hide resolved
Copy link
Contributor

@jar-stripe jar-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non blocking comment about the output, but otherwise makes sense!

@xavdid-stripe xavdid-stripe merged commit 5304640 into master Jan 17, 2025
14 checks passed
@xavdid-stripe xavdid-stripe deleted the fix-generation branch January 17, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants